Tomcat and Jetty metrics Auto-configurations should be enabled only for servlet-based web application #45879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or servlet-based web application It's possible that Tomcat's `Manager.class` or Jetty's `Server.class` is present in reactive web applications. Signed-off-by: Yanming Zhou <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
|
@quaff These metrics seem to apply to both reactive and servlet applications. Can you explain why they don't make sense for reactive apps? |
With my understanding, both Tomcat and Jetty are servlet container, reactive applications will not start them, feel free to close it if I'm wrong. |
bclozel
added
status: declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible that Tomcat's
Manager.classor Jetty'sServer.classis present in reactive web applications.